[PATCH v2 11/12] drm/mgag200: Reserve video memory for cursor plane

Thomas Zimmermann tzimmermann at suse.de
Tue Sep 24 08:14:17 UTC 2019


Hi

Am 24.09.19 um 09:55 schrieb Gerd Hoffmann:
>    Hi,
> 
>> +	/*
>> +	 * At the high end of video memory, we reserve space for
>> +	 * buffer objects. The cursor plane uses this memory to store
>> +	 * a double-buffered image of the current cursor. Hence, it's
>> +	 * not available for framebuffers.
>> +	 */
>> +	mdev->vram_fb_available -= 2 * size;
> 
> Hmm, that looks like a leftover from the previous version of the patch
> series ...

This belongs here. For several tests the size of the available 
framebuffer memory needs to be known. It's stored in 
mdev->vram_fb_available. mgag200_mm_init() sets the value of 
mdev->vram_fb_available to the full size of the video RAM. The line 
above subtracts the size of 2 cursor buffers.

Best regards
Thomas

> 
> cheers,
>    Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)


More information about the dri-devel mailing list