[PATCH 1/3] drm/ttm: fix busy reference in ttm_mem_evict_first
Thomas Hellström (VMware)
thomas_os at shipmail.org
Wed Sep 25 11:55:47 UTC 2019
On 9/25/19 12:55 PM, Christian König wrote:
> The busy BO might actually be already deleted,
> so grab only a list reference.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 881cf26d698e..02f301e1ff29 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -875,11 +875,11 @@ static int ttm_mem_evict_first(struct ttm_bo_device *bdev,
>
> if (!bo) {
> if (busy_bo)
> - ttm_bo_get(busy_bo);
> + kref_get(&busy_bo->list_kref);
> spin_unlock(&glob->lru_lock);
> ret = ttm_mem_evict_wait_busy(busy_bo, ctx, ticket);
> if (busy_bo)
> - ttm_bo_put(busy_bo);
> + kref_put(&busy_bo->list_kref, ttm_bo_release_list);
> return ret;
> }
>
lgtm.
Reviewed-by: Thomas Hellström <thellstrom at vmware.com>
More information about the dri-devel
mailing list