Ack to merge through DRM? WAS Re: [PATCH v2 1/5] mm: Add write-protect and clean utilities for address space ranges

Linus Torvalds torvalds at linux-foundation.org
Thu Sep 26 19:19:14 UTC 2019


On Thu, Sep 26, 2019 at 5:03 AM Thomas Hellström (VMware)
<thomas_os at shipmail.org> wrote:
>
> I wonder if I can get an ack from an mm maintainer to merge this through
> DRM along with the vmwgfx patches? Andrew? Matthew?

It would have helped to actually point to the patch itself, instead of
just quoting the commit message.

Looks like this:

     https://lore.kernel.org/lkml/20190926115548.44000-2-thomas_os@shipmail.org/

but why is the code in question not just using the regular page
walkers. The commit log shows no explanation of what's so special
about this?

Is the only reason the locking magic? Because if that's the reason,
then afaik we already have a function for that: it's
__walk_page_range().

Yes, it's static right now, but that's imho not a reason to duplicate
all the walking (badly).

Is there some other magic reason that isn't documented?

              Linus


More information about the dri-devel mailing list