[Nouveau] Is Nouveau really using the io_reserve_lru?

Ben Skeggs skeggsb at gmail.com
Thu Sep 26 21:44:19 UTC 2019


On Tue, 24 Sep 2019 at 22:19, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> Hi guys,
>
> while working through more old TTM functionality I stumbled over the
> io_reserve_lru.
>
> Basic idea is that when this flag is set the driver->io_mem_reserve()
> callback can return -EAGAIN resulting in unmapping of other BOs.
>
> But Nouveau doesn't seem to return -EAGAIN in the call path of
> io_mem_reserve anywhere.
I believe this is a bug in Nouveau.  We *should* be returning -EAGAIN
if we fail to find space in BAR1 to map the BO into.

Ben.
>
> So is this unused or am I missing something?
>
> Regards,
> Christian.
> _______________________________________________
> Nouveau mailing list
> Nouveau at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau


More information about the dri-devel mailing list