[PATCH] dma-buf/resv: fix exclusive fence get

[Koenig, Christian]

Am 30.09.19 um 09:22 schrieb Daniel Vetter:
> On Sun, Sep 22, 2019 at 2:08 PM Qiang Yu <yuq825 at gmail.com> wrote:
>> This causes kernel crash when testing lima driver.
>>
>> Cc: Christian König <christian.koenig at amd.com>
>> Fixes: b8c036dfc66f ("dma-buf: simplify reservation_object_get_fences_rcu a bit")
>> Signed-off-by: Qiang Yu <yuq825 at gmail.com>
> Selftest for this would be lovely, now that the basic infrastructure
> is in place ...

What do you have in mind? I wouldn't even know where to start to write 
an unit test for this.

Christian.

> -Daniel
>
>> ---
>>   drivers/dma-buf/dma-resv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
>> index 42a8f3f11681..709002515550 100644
>> --- a/drivers/dma-buf/dma-resv.c
>> +++ b/drivers/dma-buf/dma-resv.c
>> @@ -471,7 +471,7 @@ int dma_resv_get_fences_rcu(struct dma_resv *obj,
>>          if (pfence_excl)
>>                  *pfence_excl = fence_excl;
>>          else if (fence_excl)
>> -               shared[++shared_count] = fence_excl;
>> +               shared[shared_count++] = fence_excl;
>>
>>          if (!shared_count) {
>>                  kfree(shared);
>> --
>> 2.17.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>