lima, panfrost: multiple definition of `of_devfreq_cooling_register_power'

[Thomas Zimmermann]

Hi Martin

Am 02.04.20 um 09:39 schrieb Martin Blumenstingl:
> Hi Thomas,
> 
> On Thu, Apr 2, 2020 at 9:26 AM Thomas Zimmermann <tzimmermann at suse.de> wrote:
>>
>> Hi,
>>
>> building lima and panfrost drivers from drm-tip, I currently get the
>> following linker error
>>
>>   > make clean
>>   > make
>>   [...]
>>   LD      vmlinux.o
>>   arm-suse-linux-gnueabi-ld: drivers/gpu/drm/panfrost
>>         /panfrost_devfreq.o: in function
>>         `of_devfreq_cooling_register_power':
>>   panfrost_devfreq.c:(.text+0x18c): multiple definition of
>>         `of_devfreq_cooling_register_power'; drivers/gpu/drm/lima
>>         /lima_devfreq.o:lima_devfreq.c:(.text+0x1a0): first defined here
>>   make[1]: *** [/home/tzimmermann/Projekte/linux/Makefile:1078: vmlinux]
>>         Error 1
>>   make[1]: Leaving directory '/home/tzimmermann/Projekte/linux/build-
>>         arm'
>>   make: *** [Makefile:180: sub-make] Error 2
> can you please try building again with the attached patch?

Yes, fixes the bug. Thanks for responding quickly.

> 
>> Seems related to
>>
>>   commit 1996970773a323533e1cc1b6b97f00a95d675f32
>>   Author: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
>>   Date:   Thu Mar 19 21:34:27 2020 +0100
>>
>>     drm/lima: Add optional devfreq and cooling device support
>>
>> https://cgit.freedesktop.org/drm/drm-tip/commit/?id=1996970773a323533e1cc1b6b97f00a95d675f32
> it's also possible that this was originally caused by a76caf55e5b356
> ("thermal: Add devfreq cooling") and that my commit only exposes this
> bug

True. This must have been an oversight in the original patch, as the
other placeholder functions have their static inline declared already.

Best regards
Thomas

> 
> 
> Thank you in advance!
> Regards
> Martin
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200402/b89b6b06/attachment-0001.sig>