amdgpu dropping load callback triggers WARN_ON in __drm_mode_object_add

[Daniel Vetter]

5 seconds on irc and I've found the splat ...

drm_properties need to be created at driver load time, upfront. You
can attach them to hotpluggable drm_connector objects later on, but
only before calling drm_connector_register().

The warning exists because i915 had the same bug :-)
-Daniel

On Fri, Apr 3, 2020 at 6:38 PM Daniel Vetter <daniel at ffwll.ch> wrote:
>
> On Fri, Apr 3, 2020 at 6:30 PM Michel Dänzer <michel at daenzer.net> wrote:
> >
> >
> > I'm getting the attached WARNING splats since amdgpu dropped its load
> > callback. They're from
> >
> >         WARN_ON(!dev->driver->load && dev->registered && !obj_free_cb);
> >
> > in __drm_mode_object_add.
> >
> > I'm not sure how to address this, since obj_free_cb is always NULL here,
> > and I don't think MST connectors getting added after dev->registered is
> > set can be avoided?
>
> I need the full splat, otherwise can't tell you what's going wrong.
> There's 2 cases:
>
> - hotpluggable stuff, which has the obj_free_cb set. Essentially MST connectors.
>
> - not-hotpluggable stuff, which is everything else. They don't have
> obj_free_cb set. It's a driver bug to register those after the overall
> drm_device has already been registered and published to userspace.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch