[PATCH 1/2] drm/ttm: clean up ttm_trace_dma_map/ttm_trace_dma_unmap

[Christian König]

Am 07.04.20 um 08:44 schrieb Huang Rui:
> ttm_trace_dma_map/ttm_trace_dma_unmap is never used anymore. Move the pr_fmt
> prefix into this header.
>
> Signed-off-by: Huang Rui <ray.huang at amd.com>
> ---
>   include/drm/ttm/ttm_debug.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_debug.h b/include/drm/ttm/ttm_debug.h
> index b5e460f..bd7cf37 100644
> --- a/include/drm/ttm/ttm_debug.h
> +++ b/include/drm/ttm/ttm_debug.h
> @@ -27,5 +27,5 @@
>   /*
>    * Authors: Tom St Denis <tom.stdenis at amd.com>
>    */
> -extern void ttm_trace_dma_map(struct device *dev, struct ttm_dma_tt *tt);
> -extern void ttm_trace_dma_unmap(struct device *dev, struct ttm_dma_tt *tt);

I would just completely remove the file since it isn't used any more.

> +
> +#define pr_fmt(fmt) "[TTM] " fmt

Oh, that is most likely not a good idea. The pr_fmt define should be set 
for each file individually or otherwise we could accidentally include 
the file in a driver.

Regards,
Christian.