[PATCH] drm: Don't return 0 from a void drm_fbdev_generic_setup

[Alex Deucher]

On Wed, Apr 8, 2020 at 5:24 PM Chris Wilson <chris at chris-wilson.co.uk> wrote:
>
> drm_fbdev_generic_setup() was changed to be a void return, but the stub
> was left returning 0.
>
> ./include/drm/drm_fb_helper.h: In function ‘drm_fbdev_generic_setup’:
> ./include/drm/drm_fb_helper.h:450:9: warning: ‘return’ with a value, in function returning void [-Wreturn-type]
> ./include/drm/drm_fb_helper.h:448:1: note: declared here
>   448 | drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
>
> Fixes: 1aed9509b29a ("drm/fb-helper: Remove return value from drm_fbdev_generic_setup()")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Sam Ravnborg <sam at ravnborg.org>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  include/drm/drm_fb_helper.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index fb037be83997..306aa3a60be9 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -447,7 +447,6 @@ static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev)
>  static inline void
>  drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
>  {
> -       return 0;
>  }
>
>  #endif
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel