[PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()
Bartlomiej Zolnierkiewicz
b.zolnierkie at samsung.com
Fri Apr 17 14:07:29 UTC 2020
[ added dri-devel ML to Cc: ]
On 3/24/20 6:05 PM, Andy Shevchenko wrote:
> Use the ->probe_new() callback.
>
> The driver does not use const struct i2c_device_id * argument,
> so convert it to utilise the simplified I²C driver registration.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Patch queued for v5.8, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/ssd1307fb.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 142535267fec..397eae246c2c 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -586,8 +586,7 @@ static const struct of_device_id ssd1307fb_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, ssd1307fb_of_match);
>
> -static int ssd1307fb_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ssd1307fb_probe(struct i2c_client *client)
> {
> struct backlight_device *bl;
> char bl_name[12];
> @@ -599,11 +598,6 @@ static int ssd1307fb_probe(struct i2c_client *client,
> void *vmem;
> int ret;
>
> - if (!node) {
> - dev_err(&client->dev, "No device tree data found!\n");
> - return -EINVAL;
> - }
> -
> info = framebuffer_alloc(sizeof(struct ssd1307fb_par), &client->dev);
> if (!info)
> return -ENOMEM;
> @@ -808,7 +802,7 @@ static const struct i2c_device_id ssd1307fb_i2c_id[] = {
> MODULE_DEVICE_TABLE(i2c, ssd1307fb_i2c_id);
>
> static struct i2c_driver ssd1307fb_driver = {
> - .probe = ssd1307fb_probe,
> + .probe_new = ssd1307fb_probe,
> .remove = ssd1307fb_remove,
> .id_table = ssd1307fb_i2c_id,
> .driver = {
>
More information about the dri-devel
mailing list