[PATCH 3/3] drm: pl111: Move VExpress setup into versatile init

Rob Herring robh at kernel.org
Sun Apr 19 17:12:19 UTC 2020


On Fri, Apr 17, 2020 at 3:27 PM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> On Thu, Apr 9, 2020 at 3:39 AM Rob Herring <robh at kernel.org> wrote:
>
> > Since the VExpress setup in pl111_vexpress.c is now just a single
> > function call, let's move it into pl111_versatile.c and we can further
> > simplify pl111_versatile_init() by moving the other pieces for VExpress
> > into pl111_vexpress_clcd_init().
> >
> > Cc: Eric Anholt <eric at anholt.net>
> > Cc: dri-devel at lists.freedesktop.org
> > Signed-off-by: Rob Herring <robh at kernel.org>
>
> Yeah that's much nicer, the other boards get a copy of the
> Vexpress code but it's so little so it doesn't matter and besides
> the Vexpress already had copies of the other boards init code.

It shouldn't change. The compiler should be smart enough to drop all
the code when IS_ENABLED(CONFIG_ARCH_VEXPRESS) is false.

> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Thanks.

Rob


More information about the dri-devel mailing list