[PATCH] drm/amdgpu: Remove an unnecessary null pointer check in amdgpu_cs_bo_handles_chunk()

Markus Elfring Markus.Elfring at web.de
Sun Apr 19 08:15:35 UTC 2020


> kvfree ensure that the null pointer will do nothing.

I suggest to improve the commit message.
Would you like to adjust the patch subject?

Are you looking for further questionable condition checks?


…
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -98,8 +98,7 @@ static int amdgpu_cs_bo_handles_chunk(struct amdgpu_cs_parser *p,
…
> +	kvfree(info);
>
>  	return r;
>  }

How do you think about to omit a blank line behind the function call
at this source code place?

Regards,
Markus


More information about the dri-devel mailing list