[PATCH v2] console: console: Complete exception handling in newport_probe()
Andy Shevchenko
andy.shevchenko at gmail.com
Thu Apr 23 14:52:09 UTC 2020
On Thu, Apr 23, 2020 at 5:26 PM Dejin Zheng <zhengdejin5 at gmail.com> wrote:
>
> A call of the function ¡°do_take_over_console¡± can fail here.
> The corresponding system resources were not released then.
> Thus add a call of the function ¡°iounmap¡± together with the check
> of a failure predicate.
...
> CC: Andy Shevchenko <andy.shevchenko at gmail.com>
Use Cc: Better to read.
...
> v1 -> v2:
> - modify the commit comments by Markus'suggestion.
What suggestion? You need to be clear in changelog what exactly has
been done without looking to any previous mail.
...
> console_lock();
> err = do_take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1);
> console_unlock();
> +
> + if (err)
> + iounmap((void *)npregs);
> return err;
> }
I have briefly looked at the code (it is actually quite old one!), and
I think this is half-baked solution, besides the fact of missed
__iomem annotation and useless explicit casting.
The proper one seems to switch to memremap() and do memunmap() here.
--
With Best Regards,
Andy Shevchenko
More information about the dri-devel
mailing list