[PATCH v1] console: fix an issue about ioremap leak.
Markus Elfring
Markus.Elfring at web.de
Thu Apr 23 11:10:14 UTC 2020
> if do_take_over_console() return an error in the newport_probe(),
> due to the io virtual address is not released, it will cause a leak.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] console: Complete exception handling in newport_probe()
Change description:
A call of the function “do_take_over_console” can fail here.
The corresponding system resources were not released then.
Thus add a call of the function “iounmap” together with the check
of a failure predicate.
I would like to point out that there is a script for the semantic
patch language which would detect other questionable source code.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci
How do you think about to extend presented software analysis approaches?
Regards,
Markus
More information about the dri-devel
mailing list