[PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c

Christian König christian.koenig at amd.com
Mon Apr 27 08:03:23 UTC 2020


Am 27.04.20 um 08:37 schrieb Jason Yan:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Jason Yan <yanaijie at huawei.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> index 256889eed93e..aefd29a440b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> @@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
>   	do {
>   		struct aux_payload current_payload;
>   		bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >
> -			payload->length ? true : false;
> +			payload->length;
>   
>   		current_payload.address = payload->address;
>   		current_payload.data = &payload->data[retrieved];



More information about the dri-devel mailing list