[PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR
daniel at ffwll.ch
daniel at ffwll.ch
Sat Aug 1 19:19:56 UTC 2020
On Sat, Aug 01, 2020 at 05:39:50PM +0300, Lionel Landwerlin wrote:
> On 01/08/2020 12:26, Daniel Vetter wrote:
> > Userspace can provoke this, we generally don't allow userspace to spam
> > dmesg. Tune it down to debug. Unfortunately we don't have easy access
> > to the drm_device here (not at all without changing a few things), so
> > leave it as old style dmesg output for now.
> >
> > References: https://patchwork.freedesktop.org/series/80146/
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > Cc: "Christian König" <christian.koenig at amd.com>
> > ---
> > drivers/gpu/drm/drm_syncobj.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> > index 3bf73971daf3..6e74e6745eca 100644
> > --- a/drivers/gpu/drm/drm_syncobj.c
> > +++ b/drivers/gpu/drm/drm_syncobj.c
> > @@ -297,7 +297,7 @@ void drm_syncobj_add_point(struct drm_syncobj *syncobj,
> > prev = drm_syncobj_fence_get(syncobj);
> > /* You are adding an unorder point to timeline, which could cause payload returned from query_ioctl is 0! */
> > if (prev && prev->seqno >= point)
> > - DRM_ERROR("You are adding an unorder point to timeline!\n");
> > + DRM_DEBUG("You are adding an unorder point to timeline!\n");
> > dma_fence_chain_init(chain, prev, fence, point);
> > rcu_assign_pointer(syncobj->fence, &chain->base);
>
> Thanks,
>
> Acked-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Thanks for taking a look, applied it now.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list