[PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge
kernel test robot
lkp at intel.com
Fri Aug 7 01:15:19 UTC 2020
Hi Swapnil,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.8 next-20200806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Swapnil-Jakhade/dt-bindings-drm-bridge-Document-Cadence-MHDP-bridge-bindings/20200807-011620
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-randconfig-r005-20200807 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/clk.h:13,
from drivers/gpu/drm/bridge/cdns-mhdp-core.c:14:
drivers/gpu/drm/bridge/cdns-mhdp-core.c: In function 'cdns_mhdp_link_training_init':
include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/cdns-mhdp-core.h:116:35: note: in expansion of macro 'GENMASK'
116 | #define CDNS_DP_LANE_EN_LANES(x) GENMASK((x) - 1, 0)
| ^~~~~~~
drivers/gpu/drm/bridge/cdns-mhdp-core.c:892:8: note: in expansion of macro 'CDNS_DP_LANE_EN_LANES'
892 | CDNS_DP_LANE_EN_LANES(mhdp->link.num_lanes));
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:26:40: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/cdns-mhdp-core.h:116:35: note: in expansion of macro 'GENMASK'
116 | #define CDNS_DP_LANE_EN_LANES(x) GENMASK((x) - 1, 0)
| ^~~~~~~
drivers/gpu/drm/bridge/cdns-mhdp-core.c:892:8: note: in expansion of macro 'CDNS_DP_LANE_EN_LANES'
892 | CDNS_DP_LANE_EN_LANES(mhdp->link.num_lanes));
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/cdns-mhdp-core.c: In function 'cdns_mhdp_fill_host_caps':
>> drivers/gpu/drm/bridge/cdns-mhdp-core.c:1382:2: error: implicit declaration of function 'phy_get_attrs' [-Werror=implicit-function-declaration]
1382 | phy_get_attrs(mhdp->phy, &attrs);
| ^~~~~~~~~~~~~
>> drivers/gpu/drm/bridge/cdns-mhdp-core.c:1388:19: error: 'struct phy_attrs' has no member named 'max_link_rate'
1388 | link_rate = attrs.max_link_rate;
| ^
cc1: some warnings being treated as errors
vim +/phy_get_attrs +1382 drivers/gpu/drm/bridge/cdns-mhdp-core.c
1375
1376 static void cdns_mhdp_fill_host_caps(struct cdns_mhdp_device *mhdp)
1377 {
1378 unsigned int link_rate;
1379 struct phy_attrs attrs;
1380
1381 /* Get source capabilities based on PHY attributes */
> 1382 phy_get_attrs(mhdp->phy, &attrs);
1383
1384 mhdp->host.lanes_cnt = attrs.bus_width;
1385 if (!mhdp->host.lanes_cnt)
1386 mhdp->host.lanes_cnt = 4;
1387
> 1388 link_rate = attrs.max_link_rate;
1389 if (!link_rate)
1390 link_rate = drm_dp_bw_code_to_link_rate(DP_LINK_BW_8_1);
1391 else
1392 /* PHY uses Mb/s, DRM uses tens of kb/s. */
1393 link_rate *= 100;
1394
1395 mhdp->host.link_rate = link_rate;
1396 mhdp->host.volt_swing = CDNS_VOLT_SWING(3);
1397 mhdp->host.pre_emphasis = CDNS_PRE_EMPHASIS(3);
1398 mhdp->host.pattern_supp = CDNS_SUPPORT_TPS(1) |
1399 CDNS_SUPPORT_TPS(2) | CDNS_SUPPORT_TPS(3) |
1400 CDNS_SUPPORT_TPS(4);
1401 mhdp->host.lane_mapping = CDNS_LANE_MAPPING_NORMAL;
1402 mhdp->host.fast_link = false;
1403 mhdp->host.enhanced = true;
1404 mhdp->host.scrambler = true;
1405 mhdp->host.ssc = false;
1406 }
1407
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 32705 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200807/18eaa851/attachment-0001.gz>
More information about the dri-devel
mailing list