WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

Sat Aug 8 09:37:08 UTC 2020

Hi Daniel.

On Sat, Aug 08, 2020 at 11:13:54AM +0200, Daniel Vetter wrote:
> On Fri, Aug 7, 2020 at 3:54 PM Thomas Zimmermann <tzimmermann at suse.de> wrote:
> >
> > Hi
> >
> > Am 07.08.20 um 15:30 schrieb gregkh at linuxfoundation.org:
> > > The patch below was submitted to be applied to the 5.8-stable tree.
> > >
> > > I fail to see how this patch meets the stable kernel rules as found at
> > > Documentation/process/stable-kernel-rules.rst.
> > >
> > > I could be totally wrong, and if so, please respond to
> > > <stable at vger.kernel.org> and let me know why this patch should be
> > > applied.  Otherwise, it is now dropped from my patch queues, never to be
> > > seen again.
> >
> > Sorry for the noise. There's no reason this should go into stable.
> 
> We have a little script in our maintainer toolbox for bugfixes, which
> generates the Fixes: line, adds everyone from the original commit to
> the cc: list and also adds Cc: stable if that sha1 the patch fixes is
> in a release already.
> 
> I guess we trained people a bit too much on using Fixes: tags like
> that with the tooling, since they often do that for checkpatch stuff
> and spelling fixes like this here too. I think the autoselect bot also
> loves Fixes: tags a bit too much for its own good.
> 
> Not sure what to do, since telling people to "please sprinkle less
> Fixes: tags" doesn't sound great either.

We know that at lot of the drm people uses "dim fixes".
So maybe teach them a litte here?

diff --git a/dim b/dim
index e4f4d2e..d4fd310 100755
--- a/dim
+++ b/dim
@@ -2428,6 +2428,10 @@ function dim_fixes
 
 	sha1=${1:?$usage}
 
+	echo ""
+	echo "Note: Patch must meet the stable-kernel-rules criterias (Documentation/process/stable-kernel-rules.rst)"
+	echo ""
+
 	cd $DIM_PREFIX/$DIM_REPO
 	echo "Fixes: $(dim_cite $sha1)"
 

Output would then look like this:

$ dim fixes 1d8d42ba365101fa68d210c0e2ed2bc9582fda6c

Note: Patch must meet the stable-kernel-rules criterias (Documentation/process/stable-kernel-rules.rst)

Fixes: 1d8d42ba3651 ("drm/mgag200: Remove declaration of mgag200_mmap() from header file")
Cc: Thomas Zimmermann <tzimmermann at suse.de>
Cc: Sam Ravnborg <sam at ravnborg.org>
Cc: Gerd Hoffmann <kraxel at redhat.com>
Cc: Dave Airlie <airlied at redhat.com>
Cc: Krzysztof Kozlowski <krzk at kernel.org>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Thomas Gleixner <tglx at linutronix.de>
Cc: "Noralf Trønnes" <noralf at tronnes.org>
Cc: Armijn Hemel <armijn at tjaldur.nl>
Cc: Alex Deucher <alexander.deucher at amd.com>
Cc: Emil Velikov <emil.velikov at collabora.com>
Cc: <stable at vger.kernel.org> # v5.3+
Cc: Lyude Paul <lyude at redhat.com>

No guarantee that people will look up the rules outlined in
stable-kernel-rules.rst - but at least a reminder.

	Sam

> I also don't want to tell
> people to use the maintainer toolbox less, the autogenerated cc: list
> is generally the right thing to do. Maybe best if the stable team
> catches the obvious ones before adding them to the stable queue, if
> you're ok with that Greg?
> 
> Also adding dri-devel here in case this becomes a bigger discussion.
> 
> Cheers, Daniel
> 
> >
> > Best regards
> > Thomas
> >
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> > > ------------------ original commit in Linus's tree ------------------
> > >
> > > From 1d8d42ba365101fa68d210c0e2ed2bc9582fda6c Mon Sep 17 00:00:00 2001
> > > From: Thomas Zimmermann <tzimmermann at suse.de>
> > > Date: Fri, 5 Jun 2020 15:57:50 +0200
> > > Subject: [PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header
> > >  file
> > > MIME-Version: 1.0
> > > Content-Type: text/plain; charset=UTF-8
> > > Content-Transfer-Encoding: 8bit
> > >
> > > Commit 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM")
> > > removed the implementation of mgag200_mmap(). Also remove the declaration.
> > >
> > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> > > Acked-by: Sam Ravnborg <sam at ravnborg.org>
> > > Fixes: 94668ac796a5 ("drm/mgag200: Convert mgag200 driver to VRAM MM")
> > > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > > Cc: Dave Airlie <airlied at redhat.com>
> > > Cc: Krzysztof Kozlowski <krzk at kernel.org>
> > > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > Cc: Sam Ravnborg <sam at ravnborg.org>
> > > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > > Cc: Thomas Gleixner <tglx at linutronix.de>
> > > Cc: "Noralf Trønnes" <noralf at tronnes.org>
> > > Cc: Armijn Hemel <armijn at tjaldur.nl>
> > > Cc: Alex Deucher <alexander.deucher at amd.com>
> > > Cc: Emil Velikov <emil.velikov at collabora.com>
> > > Cc: <stable at vger.kernel.org> # v5.3+
> > > Link: https://patchwork.freedesktop.org/patch/msgid/20200605135803.19811-2-tzimmermann@suse.de
> > >
> > > diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h
> > > index 47df62b1ad29..92b6679029fe 100644
> > > --- a/drivers/gpu/drm/mgag200/mgag200_drv.h
> > > +++ b/drivers/gpu/drm/mgag200/mgag200_drv.h
> > > @@ -198,6 +198,5 @@ void mgag200_i2c_destroy(struct mga_i2c_chan *i2c);
> > >
> > >  int mgag200_mm_init(struct mga_device *mdev);
> > >  void mgag200_mm_fini(struct mga_device *mdev);
> > > -int mgag200_mmap(struct file *filp, struct vm_area_struct *vma);
> > >
> > >  #endif                               /* __MGAG200_DRV_H__ */
> > >
> >
> > --
> > Thomas Zimmermann
> > Graphics Driver Developer
> > SUSE Software Solutions Germany GmbH
> > Maxfeldstr. 5, 90409 Nürnberg, Germany
> > (HRB 36809, AG Nürnberg)
> > Geschäftsführer: Felix Imendörffer
> >
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
