[PATCH] gpu: ipu-v3: remove unused functions

[Sam Ravnborg]

On Tue, Jul 21, 2020 at 03:05:04PM +0200, Philipp Zabel wrote:
> ipu_mbus_code_to_colorspace, ipu_stride_to_bytes, and
> ipu_pixelformat_is_planar are unused. Remove them.
> 
> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>

git grep agrees with you.

Reviewed-by: Sam Ravnborg <sam at ravnborg.org>

> ---
>  drivers/gpu/ipu-v3/ipu-common.c | 67 ---------------------------------
>  include/video/imx-ipu-v3.h      |  3 --
>  2 files changed, 70 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index b3dae9ec1a38..d166ee262ce4 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -133,73 +133,6 @@ enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat)
>  }
>  EXPORT_SYMBOL_GPL(ipu_pixelformat_to_colorspace);
>  
> -bool ipu_pixelformat_is_planar(u32 pixelformat)
> -{
> -	switch (pixelformat) {
> -	case V4L2_PIX_FMT_YUV420:
> -	case V4L2_PIX_FMT_YVU420:
> -	case V4L2_PIX_FMT_YUV422P:
> -	case V4L2_PIX_FMT_NV12:
> -	case V4L2_PIX_FMT_NV21:
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		return true;
> -	}
> -
> -	return false;
> -}
> -EXPORT_SYMBOL_GPL(ipu_pixelformat_is_planar);
> -
> -enum ipu_color_space ipu_mbus_code_to_colorspace(u32 mbus_code)
> -{
> -	switch (mbus_code & 0xf000) {
> -	case 0x1000:
> -		return IPUV3_COLORSPACE_RGB;
> -	case 0x2000:
> -		return IPUV3_COLORSPACE_YUV;
> -	default:
> -		return IPUV3_COLORSPACE_UNKNOWN;
> -	}
> -}
> -EXPORT_SYMBOL_GPL(ipu_mbus_code_to_colorspace);
> -
> -int ipu_stride_to_bytes(u32 pixel_stride, u32 pixelformat)
> -{
> -	switch (pixelformat) {
> -	case V4L2_PIX_FMT_YUV420:
> -	case V4L2_PIX_FMT_YVU420:
> -	case V4L2_PIX_FMT_YUV422P:
> -	case V4L2_PIX_FMT_NV12:
> -	case V4L2_PIX_FMT_NV21:
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		/*
> -		 * for the planar YUV formats, the stride passed to
> -		 * cpmem must be the stride in bytes of the Y plane.
> -		 * And all the planar YUV formats have an 8-bit
> -		 * Y component.
> -		 */
> -		return (8 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_RGB565:
> -	case V4L2_PIX_FMT_YUYV:
> -	case V4L2_PIX_FMT_UYVY:
> -		return (16 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_BGR24:
> -	case V4L2_PIX_FMT_RGB24:
> -		return (24 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_BGR32:
> -	case V4L2_PIX_FMT_RGB32:
> -	case V4L2_PIX_FMT_XBGR32:
> -	case V4L2_PIX_FMT_XRGB32:
> -		return (32 * pixel_stride) >> 3;
> -	default:
> -		break;
> -	}
> -
> -	return -EINVAL;
> -}
> -EXPORT_SYMBOL_GPL(ipu_stride_to_bytes);
> -
>  int ipu_degrees_to_rot_mode(enum ipu_rotate_mode *mode, int degrees,
>  			    bool hflip, bool vflip)
>  {
> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
> index 06b0b57e996c..d1b3889f74d8 100644
> --- a/include/video/imx-ipu-v3.h
> +++ b/include/video/imx-ipu-v3.h
> @@ -484,9 +484,6 @@ int ipu_smfc_set_watermark(struct ipu_smfc *smfc, u32 set_level, u32 clr_level);
>  
>  enum ipu_color_space ipu_drm_fourcc_to_colorspace(u32 drm_fourcc);
>  enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat);
> -enum ipu_color_space ipu_mbus_code_to_colorspace(u32 mbus_code);
> -int ipu_stride_to_bytes(u32 pixel_stride, u32 pixelformat);
> -bool ipu_pixelformat_is_planar(u32 pixelformat);
>  int ipu_degrees_to_rot_mode(enum ipu_rotate_mode *mode, int degrees,
>  			    bool hflip, bool vflip);
>  int ipu_rot_mode_to_degrees(int *degrees, enum ipu_rotate_mode mode,
> -- 
> 2.20.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel