[PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings

Linus Walleij linus.walleij at linaro.org
Wed Aug 12 07:30:17 UTC 2020


On Tue, Jul 21, 2020 at 1:28 PM Daniel Thompson
<daniel.thompson at linaro.org> wrote:

> I'm a bit sceptical of having a max-brightness in the DT and a driver
> defined lookup table in the driver itself. That doesn't make a whole lot
> of sense to me since the maximum brightness here is basically relies on
> knowing what scale the Linux driver has opted to implement in its tables.

That's a good point.

> I think there are two options here.
>
> 1. Throw away the brightness table in the driver and expose the hardware
>    steps directly (maybe using allowing properties such as
>    max-brightness = 24 if the top 8 values cannot be distinguished
>    visually).

I think I will opt for this. It makes most sense given how we use the
device tree to restrict maximum brightness, and that is definitely
related to the hardware max brightness.

Thanks Daniel!
Linus Walleij


More information about the dri-devel mailing list