Warnings with drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

Alex Deucher alexdeucher at gmail.com
Fri Aug 14 03:17:11 UTC 2020


The non-atomic modesetting code in amdgpu now spews warnings[1] with
this patch applied.  I haven't really paged the legacy locking stuff
into my head in quite a while.  Thoughts on how to proceed?

Thanks,

Alex

commit 9bcaa3fe58ab7559e71df798bcff6e0795158695
Author: Michal Orzel <michalorzel.eng at gmail.com>
Date:   Tue Apr 28 19:10:04 2020 +0200

    drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

    As suggested by the TODO list for the kernel DRM subsystem, replace
    the deprecated functions that take/drop modeset locks with new helpers.

    Signed-off-by: Michal Orzel <michalorzel.eng at gmail.com>
    Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/1588093804-30446-1-git-send-email-michalorzel.eng@gmail.com


[1] https://gitlab.freedesktop.org/drm/amd/-/issues/1224


More information about the dri-devel mailing list