[PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

Markus Elfring Markus.Elfring at web.de
Wed Aug 19 16:18:08 UTC 2020


> When of_property_read_u32_array() returns an error code,
> a pairing refcount decrement is needed to keep np's refcount balanced.

Can another imperative wording be helpful for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151

Would an other commit message be a bit nicer?


…
> +++ b/drivers/video/backlight/sky81452-backlight.c
> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
>  					num_entry);
>  		if (ret < 0) {
>  			dev_err(dev, "led-sources node is invalid.\n");
> +			of_node_put(np);
>  			return ERR_PTR(-EINVAL);
>  		}

I propose to add the jump target “put_node” so that a bit of common exception
handling code can be better reused at the end of this function implementation.

Regards,
Markus


More information about the dri-devel mailing list