[PATCH] drm/bridge: tc358767: fix EDID memory leak
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Aug 26 23:23:22 UTC 2020
Hi Tomi,
Thank you for the patch.
On Wed, Aug 26, 2020 at 04:40:17PM +0300, Tomi Valkeinen wrote:
> The current EDID allocated with drm_get_edid() is freed when the driver
> gets a new EDID, but it is not freed when the driver is removed, causing
> a leak.
>
> Free the EDID (if any) on driver remove.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index c2777b226c75..dbb18a86beaf 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -1695,6 +1695,8 @@ static int tc_remove(struct i2c_client *client)
> drm_bridge_remove(&tc->bridge);
> drm_dp_aux_unregister(&tc->aux);
>
> + kfree(tc->edid);
> +
tc->edid is gone in drm-misc-next, problem solved already :-)
> return 0;
> }
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list