[bug report] drm/mcde: Add new driver for ST-Ericsson MCDE

[Dan Carpenter]

Hello Linus Walleij,

The patch 5fc537bfd000: "drm/mcde: Add new driver for ST-Ericsson
MCDE" from May 24, 2019, leads to the following static checker
warning:

	drivers/gpu/drm/mcde/mcde_display.c:570 mcde_configure_channel()
	error: uninitialized symbol 'val'.

drivers/gpu/drm/mcde/mcde_display.c
   552          case MCDE_VIDEO_TE_FLOW:
   553                  val = MCDE_CHNLXSYNCHMOD_SRC_SYNCH_HARDWARE
   554                          << MCDE_CHNLXSYNCHMOD_SRC_SYNCH_SHIFT;
   555                  val |= MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_TE0
   556                          << MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_SHIFT;
   557                  break;
   558          case MCDE_VIDEO_FORMATTER_FLOW:
   559                  val = MCDE_CHNLXSYNCHMOD_SRC_SYNCH_HARDWARE
   560                          << MCDE_CHNLXSYNCHMOD_SRC_SYNCH_SHIFT;
   561                  val |= MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_FORMATTER
   562                          << MCDE_CHNLXSYNCHMOD_OUT_SYNCH_SRC_SHIFT;
   563                  break;
   564          default:
   565                  dev_err(mcde->dev, "unknown flow mode %d\n",
   566                          mcde->flow_mode);

"val" not initialized on this path.

   567                  break;
   568          }
   569  
   570          writel(val, mcde->regs + sync);
   571  
   572          /* Set up pixels per line and lines per frame */

regards,
dan carpenter