[PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
Thomas Zimmermann
tzimmermann at suse.de
Tue Dec 1 10:06:15 UTC 2020
Hi
Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix a few W=1 warnings about unused assignments.
> Drop the unused error code.
>
> v2:
> - Subject updated (Lee)
>
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Qilong Zhang <zhangqilong3 at huawei.com>
> Cc: "Alexander A. Klimov" <grandmaster at al2klimov.de>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Lee Jones <lee.jones at linaro.org>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
> drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
> index 726c190862d4..e6363a420933 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
> @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
> struct hdmi_audio_format audio_format;
> struct hdmi_audio_dma audio_dma;
> struct hdmi_core_audio_config acore;
> - int err, n, cts, channel_count;
> + int n, cts, channel_count;
> unsigned int fs_nr;
> bool word_length_16b = false;
>
> @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
> return -EINVAL;
> }
>
> - err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
> + hdmi_compute_acr(pclk, fs_nr, &n, &cts);
I'd rather return the error reported by hdmi_compute_acr()
Best regards
Thomas
>
> /* Audio clock regeneration settings */
> acore.n = n;
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> index eda29d3032e1..cb63bc0e92ca 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
> struct hdmi_audio_format audio_format;
> struct hdmi_audio_dma audio_dma;
> struct hdmi_core_audio_config core_cfg;
> - int err, n, cts, channel_count;
> + int n, cts, channel_count;
> unsigned int fs_nr;
> bool word_length_16b = false;
>
> @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
> return -EINVAL;
> }
>
> - err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
> + hdmi_compute_acr(pclk, fs_nr, &n, &cts);
> core_cfg.n = n;
> core_cfg.cts = cts;
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201201/a02a0a3e/attachment.sig>
More information about the dri-devel
mailing list