[PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning

[Thomas Zimmermann]

Hi

Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix W=1 warning by deleting unused local variable.
> 
> v2:
>    - Updated subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Michal Januszewski <spock at gentoo.org>
> Cc: linux-fbdev at vger.kernel.org
> Cc: Lee Jones <lee.jones at linaro.org>
> ---
>   drivers/video/fbdev/uvesafb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index def14ac0ebe1..8ee0fc9c63cf 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -554,12 +554,12 @@ static int uvesafb_vbe_getmodes(struct uvesafb_ktask *task,
>   static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
>   			      struct uvesafb_par *par)
>   {
> -	int i, err;
> +	int i;
>   
>   	uvesafb_reset(task);
>   	task->t.regs.eax = 0x4f0a;
>   	task->t.regs.ebx = 0x0;
> -	err = uvesafb_exec(task);
> +	uvesafb_exec(task);

Would it be better to report the error here?

Best regards
Thomas

>   
>   	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
>   		par->pmi_setpal = par->ypan = 0;
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201201/9ac17811/attachment.sig>