Hi,
On Tue, Dec 1, 2020 at 12:28 PM Sam Ravnborg <sam at ravnborg.org> wrote:
>
> Hi Doug,
>
> On Tue, Dec 01, 2020 at 10:53:17AM -0800, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Nov 30, 2020 at 10:26 AM Sam Ravnborg <sam at ravnborg.org> wrote:
> > >
> > > When applying a patch to add the BOE NV110WTM-N61 panel I forgot
> > > to add the changes that added flags to drm_display_mode.
> >
> > Sorry, I didn't mean to make more work for you!
> >
> >
> > > Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> > > Fixes: a96ee0f6b58d ("drm: panel: simple: Add BOE NV110WTM-N61")
> > > Cc: Douglas Anderson <dianders at chromium.org>
> > > Cc: Sam Ravnborg <sam at ravnborg.org>
> > > Cc: Thierry Reding <thierry.reding at gmail.com>
> > > Cc: dri-devel at lists.freedesktop.org
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index 216cde33b5c4..2d093b5a513c 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -1367,6 +1367,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
> > > .vsync_start = 800 + 3,
> > > .vsync_end = 800 + 3 + 5,
> > > .vtotal = 800 + 3 + 5 + 24,
> > > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> > > },
> > > {
> > > .clock = 57500,
> > > @@ -1378,6 +1379,7 @@ static const struct drm_display_mode boe_nv101wxmn51_modes[] = {
> > > .vsync_start = 800 + 3,
> > > .vsync_end = 800 + 3 + 5,
> > > .vtotal = 800 + 3 + 5 + 24,
> > > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
> >
> > I think you're off by 10 and a letter.
> >
> > The subject talks about:
> > NV110WTM-N61
> >
> > You're modifying the structs for:
> > NV101WXM-N51
> >
> > I'm happy to post this if it's helpful to you, or I can review a v2
> > from you. :-)
> Please do so, that would be very nice.
Breadcrumbs: this can be found at:
https://lore.kernel.org/r/20201201125554.v2.1.I8a7bfc0966e803ab91001c9e6d01a736950c4981@changeid
-Doug