[PATCH v3 1/4] irq: export kstat_irqs

Jarkko Sakkinen jarkko at kernel.org
Sat Dec 5 10:39:54 UTC 2020


On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote:
> To try and detect potential interrupt storms that
> have been occurring with tpm_tis devices it was suggested
> to use kstat_irqs() to get the number of interrupts.
> Since tpm_tis can be built as a module it needs kstat_irqs
> exported.

I think you should also have a paragraph explicitly stating that
i915_pmu.c contains a duplicate of kstat_irqs() because it is not
exported as of today. It adds a lot more weight to this given that
there is already existing mainline usage (kind of).

> 
> Reported-by: kernel test robot <lkp at intel.com>

I'm not sure if this makes much sense.

> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: Jarkko Sakkinen <jarkko at kernel.org>
> Cc: Jason Gunthorpe <jgg at ziepe.ca>
> Cc: Peter Huewe <peterhuewe at gmx.de>
> Cc: James Bottomley <James.Bottomley at HansenPartnership.com>
> Cc: Matthew Garrett <mjg59 at google.com>
> Cc: Hans de Goede <hdegoede at redhat.com>
> Signed-off-by: Jerry Snitselaar <jsnitsel at redhat.com>

/Jarkko


More information about the dri-devel mailing list