[PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

Sam Ravnborg sam at ravnborg.org
Sun Dec 6 21:48:14 UTC 2020


commit aa1f4345b5480502a4e61addf5c59d606fdbce8f
Author: Sam Ravnborg <sam at ravnborg.org>
Date:   Mon Nov 30 22:09:29 2020 +0100

    sh: Fix set but not used warnings with !CONFIG_MMU
    
    Building fbdev drivers for sh with W=1 produces the following warning:
    
        tmiofb.c: In function ‘tmiofb_remove’:
        tmiofb.c:805:21: warning: variable ‘par’ set but not used
    
    This is with allmodconfig and ARCH=sh
    
    This boiled down to iounmap() defined as empty for !CONFIG_MMU.
    Fix this by by adding "(void)addr;" to tell the compiler the
    argument to iounmap() should be considered used.
    
    v4:
      - Fix build error of ethernet driver (kernel test robot)
        Added missing () around macro parameter
    
    Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
    Cc: kernel test robot <lkp at intel.com>
    Cc: Thomas Zimmermann <tzimmermann at suse.de>
    Cc: Lee Jones <lee.jones at linaro.org>
    Cc: Rich Felker <dalias at libc.org>
    Cc: Arnd Bergmann <arnd at arndb.de>
    Cc: Geert Uytterhoeven <geert+renesas at glider.be>
    Cc: Mike Rapoport <rppt at kernel.org>
    Cc: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
    Cc: Peter Zijlstra <peterz at infradead.org>
    Cc: Sam Ravnborg <sam at ravnborg.org>
    Cc: Andrew Morton <akpm at linux-foundation.org>

diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
index 6d5c6463bc07..45082bcbd9aa 100644
--- a/arch/sh/include/asm/io.h
+++ b/arch/sh/include/asm/io.h
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)(addr); } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 


More information about the dri-devel mailing list