[PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region

Xiong, Jianxin jianxin.xiong at intel.com
Tue Dec 8 19:33:02 UTC 2020


> -----Original Message-----
> From: Jason Gunthorpe <jgg at ziepe.ca>
> Sent: Tuesday, December 08, 2020 10:59 AM
> To: Xiong, Jianxin <jianxin.xiong at intel.com>
> Cc: Leon Romanovsky <leon at kernel.org>; linux-rdma at vger.kernel.org; dri-devel at lists.freedesktop.org; Doug Ledford
> <dledford at redhat.com>; Sumit Semwal <sumit.semwal at linaro.org>; Christian Koenig <christian.koenig at amd.com>; Vetter, Daniel
> <daniel.vetter at intel.com>
> Subject: Re: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region
> 
> On Tue, Dec 08, 2020 at 06:13:20PM +0000, Xiong, Jianxin wrote:
> 
> > > > +static inline struct ib_umem *ib_umem_dmabuf_get(struct ib_device *device,
> > > > +						 unsigned long offset,
> > > > +						 size_t size, int fd,
> > > > +						 int access,
> > > > +						 struct dma_buf_attach_ops *ops) {
> > > > +	return ERR_PTR(-EINVAL);
> > >
> > > Probably, It should be EOPNOTSUPP and not EINVAL.
> >
> > EINVAL is used here to be consistent with existing definitions in the same file.
> 
> They may be wrong, EOPNOTSUPP is right for this situation

Ok, let me change all of them to EOPNOTSUPP.



More information about the dri-devel mailing list