[PATCH 1/8] drm/vc4: drv: Remove the DSI pointer in vc4_drv

[Nicolas Saenz Julienne]

On Thu, 2020-12-03 at 14:25 +0100, Maxime Ripard wrote:
> That pointer isn't used anywhere, so there's no point in keeping it.
> 
> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>

>  drivers/gpu/drm/vc4/vc4_drv.h | 1 -
>  drivers/gpu/drm/vc4/vc4_dsi.c | 9 ---------
>  2 files changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
> index c5f2944d5bc6..ee95b4327796 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.h
> +++ b/drivers/gpu/drm/vc4/vc4_drv.h
> @@ -77,7 +77,6 @@ struct vc4_dev {
>  	struct vc4_hvs *hvs;
>  	struct vc4_v3d *v3d;
>  	struct vc4_dpi *dpi;
> -	struct vc4_dsi *dsi1;
>  	struct vc4_vec *vec;
>  	struct vc4_txp *txp;
>  
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 19aab4e7e209..b1d8765795f1 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1459,7 +1459,6 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data)
>  {
>  	struct platform_device *pdev = to_platform_device(dev);
>  	struct drm_device *drm = dev_get_drvdata(master);
> -	struct vc4_dev *vc4 = to_vc4_dev(drm);
>  	struct vc4_dsi *dsi = dev_get_drvdata(dev);
>  	struct vc4_dsi_encoder *vc4_dsi_encoder;
>  	struct drm_panel *panel;
> @@ -1612,9 +1611,6 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data)
>  	if (ret)
>  		return ret;
>  
> 
> -	if (dsi->port == 1)
> -		vc4->dsi1 = dsi;
> -
>  	drm_simple_encoder_init(drm, dsi->encoder, DRM_MODE_ENCODER_DSI);
>  	drm_encoder_helper_add(dsi->encoder, &vc4_dsi_encoder_helper_funcs);
>  
> 
> @@ -1643,8 +1639,6 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data)
>  static void vc4_dsi_unbind(struct device *dev, struct device *master,
>  			   void *data)
>  {
> -	struct drm_device *drm = dev_get_drvdata(master);
> -	struct vc4_dev *vc4 = to_vc4_dev(drm);
>  	struct vc4_dsi *dsi = dev_get_drvdata(dev);
>  
> 
>  	if (dsi->bridge)
> @@ -1656,9 +1650,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>  	 */
>  	list_splice_init(&dsi->bridge_chain, &dsi->encoder->bridge_chain);
>  	drm_encoder_cleanup(dsi->encoder);
> -
> -	if (dsi->port == 1)
> -		vc4->dsi1 = NULL;
>  }
>  
> 
>  static const struct component_ops vc4_dsi_ops = {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201209/11930917/attachment.sig>