[PATCH v4 1/2] drm: automatic legacy gamma support

Philippe CORNU philippe.cornu at st.com
Mon Dec 14 13:43:05 UTC 2020


Hi Tomi,


On 12/11/20 12:42 PM, Tomi Valkeinen wrote:
> To support legacy gamma ioctls the drivers need to set
> drm_crtc_funcs.gamma_set either to a custom implementation or to
> drm_atomic_helper_legacy_gamma_set. Most of the atomic drivers do the
> latter.
> 
> We can simplify this by making the core handle it automatically.
> 
> Move the drm_atomic_helper_legacy_gamma_set() functionality into
> drm_color_mgmt.c to make drm_mode_gamma_set_ioctl() use
> drm_crtc_funcs.gamma_set if set or GAMMA_LUT property if not.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> ---
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   1 -
>   .../gpu/drm/arm/display/komeda/komeda_crtc.c  |   1 -
>   drivers/gpu/drm/arm/malidp_crtc.c             |   1 -
>   drivers/gpu/drm/armada/armada_crtc.c          |   1 -
>   drivers/gpu/drm/ast/ast_mode.c                |   1 -
>   .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    |   1 -
>   drivers/gpu/drm/drm_atomic_helper.c           |  70 -----------
>   drivers/gpu/drm/drm_color_mgmt.c              | 111 ++++++++++++++++--
>   drivers/gpu/drm/i915/display/intel_display.c  |   1 -
>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |   2 -
>   drivers/gpu/drm/mediatek/mtk_drm_crtc.c       |   1 -
>   drivers/gpu/drm/nouveau/dispnv50/head.c       |   2 -
>   drivers/gpu/drm/omapdrm/omap_crtc.c           |   1 -
>   drivers/gpu/drm/rcar-du/rcar_du_crtc.c        |   1 -
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c   |   1 -
>   drivers/gpu/drm/stm/ltdc.c                    |   1 -

For the stm part,
Reviewed-by: Philippe Cornu <philippe.cornu at st.com>

Thank you
Philippe :-)


More information about the dri-devel mailing list