[PATCH 2/4] drm/bochs: Implement struct drm_mode_config_funcs.mode_valid

Thomas Zimmermann tzimmermann at suse.de
Mon Feb 3 08:35:54 UTC 2020


Hi Gerd

Am 03.02.20 um 07:47 schrieb Gerd Hoffmann:
> On Sat, Feb 01, 2020 at 01:27:42PM +0100, Thomas Zimmermann wrote:
>> The implementation of struct drm_mode_config_funcs.mode_valid verifies
>> that enough video memory is available for a given display mode.
> 
> There is bochs_connector_mode_valid() doing the same check,
> you can drop it when hooking up drm_vram_helper_mode_valid.

Oh, didn't see it. That's more duplicated code to remove. :)

There's a helpful comment in bochs_connector_mode_valid(). Where shall I
move it?

Best regard
Thomas

> 
> cheers,
>   Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200203/e00d6564/attachment-0001.sig>


More information about the dri-devel mailing list