[PATCH v1] drm: shmobile: Platform data shan't include kernel.h

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Feb 4 19:30:50 UTC 2020


On Tue, Feb 04, 2020 at 08:26:21PM +0200, Laurent Pinchart wrote:
> On Tue, Feb 04, 2020 at 06:39:34PM +0100, Geert Uytterhoeven wrote:
> > On Tue, Feb 4, 2020 at 5:20 PM Andy Shevchenko wrote:
> > > Replace with appropriate types.h.
> > 
> > Thanks for your patch!
> > 
> > I have only one very short question: why?
> 
> Likewise :-) The patch itself looks fine, but the commit message is a
> bit terse.

The kernel.h for a long time being a dump of a lot of things. I started
cleaning it up a bit. During this I notice that developers too far too lazy to
use appropriate headers. For platform data kernel.h by definition is not
appropriate.

Any suggestion what should I put to commit message?

-- 
With Best Regards,
Andy Shevchenko




More information about the dri-devel mailing list