[PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup

Thomas Zimmermann tzimmermann at suse.de
Fri Feb 7 14:20:44 UTC 2020


Hi

Am 07.02.20 um 14:59 schrieb Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> It's not at all clear what cloning options this driver supports.
> So let's just clear possible_clones instead of setting it to some
> bogus value.
> 
> Cc: Philipp Zabel <p.zabel at pengutronix.de>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index da87c70e413b..a0a709dfba34 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -140,7 +140,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
>  	encoder->possible_crtcs = crtc_mask;
>  
>  	/* FIXME: this is the mask of outputs which can clone this output. */
> -	encoder->possible_clones = ~0;
> +	encoder->possible_clones = 0;

Maybe remove the comment as well. It's pointless.

Best regards
Thomas

>  
>  	return 0;
>  }
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200207/5875b8cd/attachment.sig>


More information about the dri-devel mailing list