[PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

[Tomi Valkeinen]

Hi Ville,

On 10/02/2020 18:03, Ville Syrjälä wrote:

> The usual approach we follow in i915 for things that affect more
> than one plane is is to collect that state into the crtc state.
> That way we get to remember it for the planes that are not part
> of the current commit.
> 
> And when we have state that affects more than one crtc that again
> get collected up one level up in what we call global state
> (basically drm_private_obj with less heavy handed locking scheme).

I'm confused. Don't we always have the full state available? Why do you need to store state into 
custom crtc-state?

Here we are interested in the x, y and z positions of all the planes on a crtc. Creating a custom 
state object and duplicating that information there seems a bit silly, as surely that information is 
tracked by DRM?

Or what am I missing here...

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki