[PATCH v1 1/1] drm: drop unused drm_crtc callback

Sam Ravnborg sam at ravnborg.org
Sat Feb 15 21:12:49 UTC 2020


On Sat, Feb 15, 2020 at 08:09:40PM +0100, Daniel Vetter wrote:
> On Sat, Feb 15, 2020 at 6:33 PM Sam Ravnborg <sam at ravnborg.org> wrote:
> >
> > struct drm_encoder_helper_funcs included a callback
> > named drm_crtc.
> >
> > There are no users left - so drop it.
> > There was one reference in drm_crtc_helper.c,
> > which checked if the value was not NULL.
> > As it was never assigned this check could be dropped.
> >
> > Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > ---
> >
> > Stumbled upon this and dediced to check if it was used.
> > Build tested with allyesconfig, allmodconfig for relevant architectures.
> 
> Nice catch!
> 
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Thanks for the quick review.

Applied and pushed out.

	Sam


More information about the dri-devel mailing list