[PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC
Paul Cercueil
paul at crapouillou.net
Fri Feb 14 19:13:53 UTC 2020
Hi Nikolaus,
Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller
<hns at goldelico.com> a écrit :
> Interrupts should not be specified by interrupt line but by
> gpio parent and reference.
>
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
If you add a Fixes tag, you should also add:
Cc: stable at vger.kernel.org
if you're fixing something older than -rc1, which is the case here
(alternatively Cc them manually, but just for these patches).
Same remark for your patch 05/12.
Cheers,
-Paul
> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 8f9d182566db..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -298,7 +298,9 @@ Optional input supply properties:
> rtc at 51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> - interrupts = <110>;
> +
> + interrupt-parent = <&gpf>;
> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> --
> 2.23.0
>
More information about the dri-devel
mailing list