[PATCH] backlight: add led-backlight driver

Tony Lindgren tony at atomide.com
Wed Feb 19 21:15:13 UTC 2020


* Pavel Machek <pavel at ucw.cz> [200219 20:54]:
> Hi!
> 
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > > 
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> > > Acked-by: Pavel Machek <pavel at ucw.cz>
> > > Reviewed-by: Daniel Thompson <daniel.thompson at linaro.org>
> > > Acked-by: Lee Jones <lee.jones at linaro.org>
> > > Acked-by: Tony Lindgren <tony at atomide.com>
> > > Tested-by: Tony Lindgren <tony at atomide.com>
> > > Signed-off-by: Pavel Machek <pavel at ucw.cz>
> > > ---
> > >  drivers/video/backlight/Kconfig  |   7 ++
> > >  drivers/video/backlight/Makefile |   1 +
> > >  drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 268 insertions(+)
> > >  create mode 100644 drivers/video/backlight/led_bl.c
> 
> > > Here's the version of the driver I have. AFAICT
> > > default-brightness-level handling is ok, so does not need to be
> > > changed.
> > > 
> > > Lee, it would be easiest for me if you could apply it to your tree and
> > > push, but given enough time I can push it to Linus, too.
> > 
> > Oh you're using quoted-printable for patches.. Got it applied now,
> > and it still works. Below is also the related dts change that
> > I tested with.
> > 
> > Feel free to pick the dts change too, naturally that should
> > not be applied before the driver.
> > 
> > If you guys instead want me to pick these both into my fixes
> > branch, just let me know and I'll do the explaining why these
> > are needed as fixes. Basically we no longer have a way to enable
> > the LCD backlight for droid4 manually starting with v5.6-rc1
> > unlike earlier.
> 
> If you are willing to do that, it looks like good solution from my
> point of view.

OK. I'll apply them but won't push out yet in case Lee is already
applying the driver change..

Pavel, care to ack the dts patch?

Regards,

Tony


More information about the dri-devel mailing list