[PATCH] drm/virtio: fix virtio-gpu resource id creation race

Chia-I Wu olvaffe at gmail.com
Thu Feb 20 18:22:30 UTC 2020


On Thu, Feb 20, 2020 at 5:30 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
> Hi John,
>
> On Thu, 20 Feb 2020 at 08:45, John Bates <jbates at chromium.org> wrote:
> >
> > The previous code was not thread safe and caused
> > undefined behavior from spurious duplicate resource IDs.
> > In this patch, an atomic_t is used instead. We no longer
> > see any duplicate IDs in tests with this change.
> >
> > Signed-off-by: John Bates <jbates at chromium.org>
> Adding a fixes tag like below makes it easier to track. Especially for
> Greg and team who are working on stable kernels.
>
> Fixes: 3e93bc2a58aa ("drm/virtio: make resource id workaround runtime
> switchable.")
FWIW, the fixes tag should refer to this commit instead

commit 16065fcdd19ddb9e093192914ac863884f308766
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Fri Feb 8 15:04:09 2019 +0100

    drm/virtio: do NOT reuse resource ids

>
> HTH
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list