[PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void.
Greg KH
gregkh at linuxfoundation.org
Thu Feb 27 12:23:13 UTC 2020
On Thu, Feb 27, 2020 at 03:02:13PM +0300, Wambui Karuga wrote:
> As a result of commit 987d65d01356 (drm: debugfs: make
> drm_debugfs_create_files() never fail) and changes to various debugfs
> functions in drm/core and across various drivers, there is no need for
> the drm_driver.debugfs_init() hook to have a return value. Therefore,
> declare it as void.
>
> Signed-off-by: Wambui Karuga <wambui.karugax at gmail.com>
> ---
> include/drm/drm_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 97109df5beac..c6ae888c672b 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -323,7 +323,7 @@ struct drm_driver {
> *
> * Allows drivers to create driver-specific debugfs files.
> */
> - int (*debugfs_init)(struct drm_minor *minor);
> + void (*debugfs_init)(struct drm_minor *minor);
Doesn't this patch break the build, or at least, cause lots of build
warnings to happen?
Fixing it all up later is good, but I don't think you want to break
things at this point in the series.
thanks,
greg k-h
More information about the dri-devel
mailing list