[PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true

Rohit Visavalia RVISAVAL at xilinx.com
Thu Feb 27 08:40:20 UTC 2020


Gentle reminder.

+ Ilia Mirkin, +Emil Velikov.

Thanks & Regards,
Rohit 

> -----Original Message-----
> From: Rohit Visavalia [mailto:rohit.visavalia at xilinx.com]
> Sent: Tuesday, February 25, 2020 3:08 PM
> To: dri-devel at lists.freedesktop.org
> Cc: Hyun Kwon <hyunk at xilinx.com>; Ranganathan Sk <rsk at xilinx.com>;
> Dhaval Rajeshbhai Shah <dshah at xilinx.com>; Varunkumar Allagadapa
> <VARUNKUM at xilinx.com>; Devarsh Thakkar <DEVARSHT at xilinx.com>; Rohit
> Visavalia <RVISAVAL at xilinx.com>
> Subject: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if
> add_property_optional returns true
> 
> gamma is a optional property then also it prints error message, so set gamma
> only if add_property_optional() returns true.
> 
> Signed-off-by: Rohit Visavalia <rohit.visavalia at xilinx.com>
> ---
>  tests/modetest/modetest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index
> b907ab3..379b9ea 100644
> --- a/tests/modetest/modetest.c
> +++ b/tests/modetest/modetest.c
> @@ -1138,7 +1138,7 @@ static void set_gamma(struct device *dev, unsigned
> crtc_id, unsigned fourcc)
> 
>  	add_property_optional(dev, crtc_id, "DEGAMMA_LUT", 0);
>  	add_property_optional(dev, crtc_id, "CTM", 0);
> -	if (!add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) {
> +	if (add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) {
>  		uint16_t r[256], g[256], b[256];
> 
>  		for (i = 0; i < 256; i++) {
> --
> 2.7.4



More information about the dri-devel mailing list