[PATCH 2/2] [RFC] drm/virtgpu: modify uapi with stride/layer_stride fix

Chia-I Wu olvaffe at gmail.com
Fri Feb 28 21:01:49 UTC 2020


On Wed, Oct 2, 2019 at 5:18 PM Gurchetan Singh
<gurchetansingh at chromium.org> wrote:
>
> On Wed, Oct 2, 2019 at 1:49 AM Gerd Hoffmann <kraxel at redhat.com> wrote:
> >
> > On Tue, Oct 01, 2019 at 06:49:35PM -0700, Gurchetan Singh wrote:
> > > This doesn't really break userspace, since it always passes down
> > > 0 for stride/layer_stride currently. We could:
> > >
> > > (1) modify UAPI now and add a VIRTGPU_PARAM_STRIDE_FIX feature
> >
> > This I think.
> > But IMO it's not a fix, it is an added feature ...
> >
> > Also missing the big picture here.  Why do we need this?
>
> Two reasons:
I don't fully get the picture, but drm_virtgpu_resource_create has
stride.  Can we send that down in transfers?  It lacks layer_stride
though...


More information about the dri-devel mailing list