[PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels
Sam Ravnborg
sam at ravnborg.org
Sat Jan 4 17:27:17 UTC 2020
Hi Linus.
On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote:
> This adds device tree bindings for the Novatek NT35510-based
> family of panels. Since several such panels are in existence
> we define bindings common for all, and define the compatible
> string for one certain panel (Hydis HVA40WV1).
>
> As other panels are discovered and investigated, we can add
> more compatibles to the binding.
>
> Cc: Stephan Gerhold <stephan at gerhold.net>
> Cc: devicetree at vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> .../display/panel/novatek-nt35510.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> new file mode 100644
> index 000000000000..a4a6b5adf15b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT35510-based display panels
> +
> +maintainers:
> + - Linus Walleij <linus.walleij at linaro.org>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: hydis,hva40wv1
compatible fail to match filename - which is common practice.
And hydis is not a known vendor-prefix.
> + description: This indicates the panel manufacturer of the panel
> + that is in turn using the NT35510 panel driver. The compatible
> + string determines how the NT35510 panel driver shall be configured
> + to work with the indicated panel.
The description is just a general description of what compatible is used
for.
Please drop it as it does not provide anything specific for the panel.
Sam
> + reg: true
> + reset-gpios: true
> + vdd-supply:
> + description: regulator that supplies the vdd voltage
> + vddi-supply:
> + description: regulator that supplies the vddi voltage
> + backlight: true
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi at a0351000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel {
> + compatible = "hydis,hva40wv1";
> + reg = <0>;
> + vdd-supply = <&ab8500_ldo_aux4_reg>;
> + vddi-supply = <&ab8500_ldo_aux6_reg>;
> + reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
> + backlight = <&gpio_bl>;
> + };
> + };
> +
> +...
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list