[PATCH v6 2/4] drm/bridge: Patch atomic hooks to take a drm_bridge_state

Boris Brezillon boris.brezillon at collabora.com
Mon Jan 6 14:40:26 UTC 2020


On Mon,  6 Jan 2020 15:34:07 +0100
Neil Armstrong <narmstrong at baylibre.com> wrote:

> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 8ffa4fbbdeb3..b8b22dc55bdb 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -590,8 +590,9 @@ static void __rcar_lvds_atomic_enable(struct drm_bridge *bridge,
>  }
>  
>  static void rcar_lvds_atomic_enable(struct drm_bridge *bridge,
> -				    struct drm_atomic_state *state)
> +				    struct drm_bridge_state *old_bridge_state)
>  {
> +	struct drm_atomic_state *state = old_bridge_state->base.state;
>  	struct drm_connector *connector;
>  	struct drm_crtc *crtc;
>  
> @@ -603,7 +604,7 @@ static void rcar_lvds_atomic_enable(struct drm_bridge *bridge,
>  }
>  
>  static void rcar_lvds_atomic_disable(struct drm_bridge *bridge,
> -				     struct drm_atomic_state *state)
> +				     struct drm_bridge_state *state)

Just a nit: maybe you should name that one old_bridge_state for
consistency.

>  {
>  	struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge);
>  


More information about the dri-devel mailing list