[PATCH v10 6/6] backlight: add led-backlight driver

Pavel Machek pavel at ucw.cz
Tue Jan 7 13:45:40 UTC 2020


Hi!

> > * Jean-Jacques Hiblot <jjhiblot at ti.com> [700101 00:00]:
> > > From: Tomi Valkeinen <tomi.valkeinen at ti.com>
> > > 
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > ...
> > 
> > > +	ret = of_property_read_u32(node, "default-brightness", &value);
> > > +	if (!ret && value <= priv->max_brightness)
> > > +		priv->default_brightness = value;
> > > +	else if (!ret  && value > priv->max_brightness)
> > > +		dev_warn(dev, "Invalid default brightness. Ignoring it\n");
> > 
> > Hmm so just wondering.. Are we using "default-brightness" instead of the
> > usual "default-brightness-level" here?
> 
> Did this get answered?
> 
> > Please Cc me on the next patchset too :)
> 
> I've been waiting for v11.

I guess I could just remove it from a merge for now if there's no other
fix.

Best regards,
								Pavel


More information about the dri-devel mailing list