[PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

[Jyri Sarha]

On 15/01/2020 19:13, Sam Ravnborg wrote:
> Hi Jyri.
> 
>> Well, I'll bite the bullet then, and start mangling the code to the
>> "strict" format.
> 
> While touching the code please consider moving all logging
> over to the new drm_{err,warn,info,dbg} functions.
> They give the nice "[drm]" marker.
> And they are a tad shorter as you do not have to dereference ddev->dev
> everywhere.
> And you then also gain support for controlling logging using
> drm.debug=0xxxx, os sysfs too.
> 
> See drm_print.h in latest drm_misc_next

After checking out the drm_print.h, I don't think I am willing to do the
switch at least at this time. The drm print functions do not offer much
over the dev_* functions for individual driver debug, and since there is
no 1-to-1 relation from dev_* print functions to drm_* functions I would
have to rethink each print separately. And worst of all the drm prints
do not show in <debugfs>/dynamic_debug/control (requires
CONFIG_DYNAMIC_DEBUG=y).

> 
> With or without this change you can add my:
> Acked-by: Sam Ravnborg <sam at ravnborg.org>
> 
> 	Sam
> 

Thanks,
Jyri

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki