[PATCH 3/7] drm/amd/display: use drm_dsc_dp_rc_buffer_size() to get rc buffer size
Jani Nikula
jani.nikula at intel.com
Wed Jan 22 13:45:09 UTC 2020
Use the new drm_dsc_dp_rc_buffer_size() helper to simplify rc buffer
size computation. No functional changes.
Cc: Alex Deucher <alexdeucher at gmail.com>
Cc: Harry Wentland <hwentlan at amd.com>
Cc: Manasi Navare <manasi.d.navare at intel.com>
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 37 ++++-----------------
1 file changed, 7 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
index 8b78fcbfe746..6dcfe049e5b8 100644
--- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
+++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
@@ -85,31 +85,6 @@ static uint32_t dc_dsc_bandwidth_in_kbps_from_timing(
}
-static bool dsc_buff_block_size_from_dpcd(int dpcd_buff_block_size, int *buff_block_size)
-{
-
- switch (dpcd_buff_block_size) {
- case DP_DSC_RC_BUF_BLK_SIZE_1:
- *buff_block_size = 1024;
- break;
- case DP_DSC_RC_BUF_BLK_SIZE_4:
- *buff_block_size = 4 * 1024;
- break;
- case DP_DSC_RC_BUF_BLK_SIZE_16:
- *buff_block_size = 16 * 1024;
- break;
- case DP_DSC_RC_BUF_BLK_SIZE_64:
- *buff_block_size = 64 * 1024;
- break;
- default: {
- dm_error("%s: DPCD DSC buffer size not recognized.\n", __func__);
- return false;
- }
- }
-
- return true;
-}
-
static bool dsc_line_buff_depth_from_dpcd(int dpcd_line_buff_bit_depth, int *line_buff_bit_depth)
{
@@ -772,14 +747,16 @@ bool dc_dsc_parse_dsc_dpcd(const struct dc *dc, const uint8_t *dpcd_dsc_basic_da
dsc_sink_caps->dsc_version = dpcd_dsc_basic_data[DP_DSC_REV - DP_DSC_SUPPORT];
{
- int buff_block_size;
- int buff_size;
+ u8 buff_block_size = dpcd_dsc_basic_data[DP_DSC_RC_BUF_BLK_SIZE - DP_DSC_SUPPORT];
+ u8 buff_size = dpcd_dsc_basic_data[DP_DSC_RC_BUF_SIZE - DP_DSC_SUPPORT];
+ int size = drm_dsc_dp_rc_buffer_size(buff_block_size, buff_size);
- if (!dsc_buff_block_size_from_dpcd(dpcd_dsc_basic_data[DP_DSC_RC_BUF_BLK_SIZE - DP_DSC_SUPPORT], &buff_block_size))
+ if (!size) {
+ dm_error("%s: DPCD DSC buffer size not recognized.\n", __func__);
return false;
+ }
- buff_size = dpcd_dsc_basic_data[DP_DSC_RC_BUF_SIZE - DP_DSC_SUPPORT] + 1;
- dsc_sink_caps->rc_buffer_size = buff_size * buff_block_size;
+ dsc_sink_caps->rc_buffer_size = size;
}
dsc_sink_caps->slice_caps1.raw = dpcd_dsc_basic_data[DP_DSC_SLICE_CAP_1 - DP_DSC_SUPPORT];
--
2.20.1
More information about the dri-devel
mailing list