[PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml
Sam Ravnborg
sam at ravnborg.org
Sat Jan 25 18:26:43 UTC 2020
Hi Maxime.
Thanks for your comments!
>
> > + - allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32-array
> > + - minItems: 3
> > + maxItems: 3
> > + items:
> > + description: min, typ, max number of pixels
>
> When minItems and maxitems are equal, you can just set one, the other
> one will be filled by the DT schemas tools.
I tried to drop minItems: 3
But it just did not work - I could not make it
accept <xx> and <xx xx xx>.
And the schema should, and does, reject <xx xx> and <xx xx xx xx>
I do not know why - I just did a trial-and-error on this.
> > + hsync-active:
> > + description: |
> > + Horizontal sync pulse.
> > + If omitted then it is not used by the hardware
> > + oneOf:
> > + - const: 0
> > + description: active low
> > + - const: 1
> > + description: active high
>
> You probably should use an enum here (and in other similar
> places). oneOf / anyOf / allOF errors are pretty cryptic, while it
> will it's really better with an enum.
Yep - enum: [0, 1] is much nicer.
Sam
More information about the dri-devel
mailing list