[PATCH] Revert "drm/sun4i: drv: Allow framebuffer modifiers in mode config"

Maxime Ripard maxime at cerno.tech
Mon Jan 27 09:43:02 UTC 2020


On Mon, Jan 27, 2020 at 09:14:19AM +0100, Paul Kocialkowski wrote:
> Hi Jernej,
>
> On Sun 26 Jan 20, 07:59, Jernej Skrabec wrote:
> > This reverts commit 9db9c0cf5895e4ddde2814360cae7bea9282edd2.
> >
> > Setting mode_config.allow_fb_modifiers manually is completely
> > unnecessary. It is set automatically by drm_universal_plane_init() based
> > on the fact if modifier list is provided or not. Even more, it breaks
> > DE2 and DE3 as they don't support any modifiers beside linear. Modifiers
> > aware applications can be confused by provided empty modifier list - at
> > least linear modifier should be included, but it's not for DE2 and DE3.
>
> Makes sense and it's apparently the norm to not report any modifier blob
> when only linear is supported, so let's stick to that.
>
> Note that when the reverted patch was applied, the core didn't set
> allow_fb_modifiers on its own yet. But it does now so let's rely on it instead.
>
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>

Applied, thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200127/ea1cf8de/attachment.sig>


More information about the dri-devel mailing list